[concurrency-interest] Code Hygiene; Unused Imports

David Holmes dcholmes at optusnet.com.au
Tue Mar 14 17:44:46 EST 2006


Matthias,

I haven't checked in detail but many of the "unused" imports are/were
actually needed to workaround a javadoc bug - ie we needed the import for
javadoc, not javac.

Not sure of the current state of the world there.

Cheers,
David Holmes

> -----Original Message-----
> From: concurrency-interest-bounces at cs.oswego.edu
> [mailto:concurrency-interest-bounces at cs.oswego.edu]On Behalf Of Ernst,
> Matthias
> Sent: Tuesday, 14 March 2006 9:24 PM
> To: concurrency-interest at cs.oswego.edu
> Subject: [concurrency-interest] Code Hygiene; Unused Imports
>
>
> Hi,
>
> as a user of IntelliJ I've become used to check the code analyzer
> "traffic light" and want to let you know that a number of files in j.u.c
> (1.5.0_06) had warnings on them ("unchecked" warnings aside):
>
> Delayed, Semaphore, ScheduledExecutorService, ExecutorService,
> CountdownLatch, ConcurrentHashMap, LockSupport, ReentrantLock,
> ReentrantReadWriteLock have unnecessary imports. DelayQueue#take
> declares an unused local "tl".
>
> As a relatively new part of J2SE the code should set an example in
> cleanliness :-)
> I haven't looked into Mustang.
>
> Cheers
> Matthias
>
> --
> Matthias Ernst
> Software Engineer
>
> tel +49.40.32 55 87.503
> fax +49.40.32 55 87.999
> matthias.ernst at coremedia.com
>
> _______________________________________________
> Concurrency-interest mailing list
> Concurrency-interest at altair.cs.oswego.edu
> http://altair.cs.oswego.edu/mailman/listinfo/concurrency-interest



More information about the Concurrency-interest mailing list